Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx based documentation #178

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Sphinx based documentation #178

merged 4 commits into from
Apr 4, 2022

Conversation

valberg
Copy link
Contributor

@valberg valberg commented Apr 1, 2022

As per #176 (and jazzband/help#237 (comment)) we should have some better docs for django-invitations. This is the first step in that direction.

@valberg valberg requested review from brylie and MrCordeiro April 1, 2022 13:58
Copy link
Contributor

@MrCordeiro MrCordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good work. Made a few comments..

docs/index.rst Outdated Show resolved Hide resolved
docs/changelog.rst Show resolved Hide resolved
README.md Show resolved Hide resolved
@valberg valberg force-pushed the docs branch 3 times, most recently from 3ce5303 to 4856dab Compare April 4, 2022 08:50
Copy link
Contributor

@MrCordeiro MrCordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost theeeeere! Just need to use the correct package name on index.rst

docs/index.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #178 (63b0122) into master (b2c2a82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   64.64%   64.64%           
=======================================
  Files          17       17           
  Lines         478      478           
=======================================
  Hits          309      309           
  Misses        169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c2a82...63b0122. Read the comment docs.

@valberg valberg merged commit a5a5cfc into jazzband:master Apr 4, 2022
@valberg valberg mentioned this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants